arm64: dts: rockchip: Add port subnodes to RK356x SATA

A patch from »Revision overlays for QNAP TSx33 devices« in state Mainline for linux-kernel

From: Heiko Stuebner <heiko@...> Date: Sun, 11 Jan 2026 19:50:31 +0100

Commit-Message

The SATA controllers on RK356x are identical to the ones found on RK3588, but don't yet provide a port sub-node. Per the datasheet the RK356x also supports the fbscp capability and has the same queue maximums. So add port sub-nodes to both sata controllers on RK356x, and move the phy properties to it. Also add phandles to the ports, so that boards can add their target-supply when available. Signed-off-by: Heiko Stuebner <heiko@...>

Patch-Comment

arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 27 ++++++++++++++++--- 1 file changed, 23 insertions(+), 4 deletions(-)

Statistics

  • 23 lines added
  • 4 lines removed

Changes

---------------- arch/arm64/boot/dts/rockchip/rk356x-base.dtsi -----------------
index b84055a77ac5..c6bd051b6a25 100644
@@ -3,6 +3,7 @@
* Copyright (c) 2021 Rockchip Electronics Co., Ltd.
*/
+#include <dt-bindings/ata/ahci.h>
#include <dt-bindings/clock/rk3568-cru.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/interrupt-controller/irq.h>
@@ -234,11 +235,20 @@ sata1: sata@fc400000 {
<&cru CLK_SATA1_RXOOB>;
clock-names = "sata", "pmalive", "rxoob";
interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
- phys = <&combphy1 PHY_TYPE_SATA>;
- phy-names = "sata-phy";
ports-implemented = <0x1>;
power-domains = <&power RK3568_PD_PIPE>;
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "disabled";
+
+ sata1_port0: sata-port@0 {
+ reg = <0>;
+ hba-port-cap = <HBA_PORT_FBSCP>;
+ phys = <&combphy1 PHY_TYPE_SATA>;
+ phy-names = "sata-phy";
+ snps,rx-ts-max = <32>;
+ snps,tx-ts-max = <32>;
+ };
};
sata2: sata@fc800000 {
@@ -248,11 +258,20 @@ sata2: sata@fc800000 {
<&cru CLK_SATA2_RXOOB>;
clock-names = "sata", "pmalive", "rxoob";
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
- phys = <&combphy2 PHY_TYPE_SATA>;
- phy-names = "sata-phy";
ports-implemented = <0x1>;
power-domains = <&power RK3568_PD_PIPE>;
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "disabled";
+
+ sata2_port0: sata-port@0 {
+ reg = <0>;
+ hba-port-cap = <HBA_PORT_FBSCP>;
+ phys = <&combphy2 PHY_TYPE_SATA>;
+ phy-names = "sata-phy";
+ snps,rx-ts-max = <32>;
+ snps,tx-ts-max = <32>;
+ };
};
usb_host0_xhci: usb@fcc00000 {
 
 

Recent Patches

About Us

Sed lacus. Donec lectus. Nullam pretium nibh ut turpis. Nam bibendum. In nulla tortor, elementum vel, tempor at, varius non, purus. Mauris vitae nisl nec metus placerat consectetuer.

Read More...