PatchTrack

From: Heiko Stuebner <heiko@...> Date: Mon, 4 Aug 2025 14:49:52 +0200

While digging through the mcu functions, I came across some deficits I introduced with the initial driver submission, so trying to make that a bit nicer with this series. I struggled a bit with the ordering of qnap_mcu_write error-check and conversion to guard(mutex). Converting to guard before the error check would need dropping the ret variable, just to re-add it one patch later - to not cause unused variable warning. Additionally the error handling could be considered a fix, so makes sense to have in front. Heiko Stuebner (4): mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared header mfd: qnap-mcu: handle errors returned from qnap_mcu_write mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec mfd: qnap-mcu: improve structure in qnap_mcu_exec drivers/mfd/qnap-mcu.c | 30 +++++++++++++++--------------- include/linux/mfd/qnap-mcu.h | 2 ++ 2 files changed, 17 insertions(+), 15 deletions(-) -- 2.47.2

Patches in this set

• [0001] mfd: qnap-mcu: include linux/types.h in qnap-mcu.h shared (raw)
• [0002] mfd: qnap-mcu: handle errors returned from qnap_mcu_write (raw)
• [0003] mfd: qnap-mcu: convert to guard(mutex) in qnap_mcu_exec (raw)
• [0004] mfd: qnap-mcu: improve structure in qnap_mcu_exec (raw)

Statistics

• 4 individual patches
• 21 lines added
• 19 lines removed