leds: qnap-mcu: fix state numbering for usb LED
From: Heiko Stuebner <heiko@...> Date: Sun, 3 Aug 2025 11:25:44 +0200
Commit-Message
The "@Cx" commands span a number of different functions, from the status and usb LEDs to the buzzer and power button. So change the usb-LED enum to start at 0 and adapt the offset accordingly to not suggest @CD would relate to the usb-LED - while in fact "@CD" is a state of the status LED. Signed-off-by: Heiko Stuebner <heiko@...>
Patch-Comment
drivers/leds/leds-qnap-mcu.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Statistics
- 5 lines added
- 5 lines removed
Changes
------------------------- drivers/leds/leds-qnap-mcu.c -------------------------
index 4e4709456261..fe055c5511b8 100644
@@ -104,9 +104,9 @@ static int qnap_mcu_register_err_led(struct device *dev, struct qnap_mcu *mcu, i
}
enum qnap_mcu_usb_led_mode {
+ QNAP_MCU_USB_LED_ON = 0,
+ QNAP_MCU_USB_LED_OFF = 2,
+ QNAP_MCU_USB_LED_BLINK = 1,
};
struct qnap_mcu_usb_led {
@@ -137,7 +137,7 @@ static int qnap_mcu_usb_led_set(struct led_classdev *led_cdev,
* Byte 3 is shared between the usb led target on/off/blink
* and also the buzzer control (in the input driver)
*/
+ cmd[2] = 'E' + usb_led->mode;
return qnap_mcu_exec_with_ack(usb_led->mcu, cmd, sizeof(cmd));
}
@@ -161,7 +161,7 @@ static int qnap_mcu_usb_led_blink_set(struct led_classdev *led_cdev,
* Byte 3 is shared between the USB LED target on/off/blink
* and also the buzzer control (in the input driver)
*/
+ cmd[2] = 'E' + usb_led->mode;
return qnap_mcu_exec_with_ack(usb_led->mcu, cmd, sizeof(cmd));
}