arm64: dts: rockchip: fix compatible string rk3328 cru

A patch from »rk3328 cru dt-binding conversion« in state Mainline for linux-kernel

From: Johan Jonker <jbx6244@...> Date: Tue, 29 Mar 2022 18:30:15 +0200

Commit-Message

The cru node references undocumented compatibles of "rockchip,cru" and also marks it as syscon. A general rockchip,cru is way too generic to ever be used anywhere, so needs to go away, similarly the cru should not be written to from other places, instead regular clock routines should be used. Both mainline Linux as well as the vendor-kernel up to their 6.1 branch only reference the cru via the normal assigned-clocks, clocks and resets properties and do not get a syscon from the node. Similarly, there is no syscon access by compatible both in mainline nor the vendor-kernel up to their 6.1 branch, through either the rockchip,rk3328-cru nor rockchip,cru compatibles. So these two really are unused in all publically visible places. Sidenote: the vendor-kernel does pretty crazy stuff in the camera interface and tdm driver, where they map the cru separately and set clock muxes and gates directly. This should of course never reach mainline anyway. Signed-off-by: Johan Jonker <jbx6244@...> [update commit message, to explain the unused compatibles] Signed-off-by: Heiko Stuebner <heiko@...>

Patch-Comment

arch/arm64/boot/dts/rockchip/rk3328.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Statistics

  • 1 lines added
  • 1 lines removed

Changes

------------------- arch/arm64/boot/dts/rockchip/rk3328.dtsi -------------------
index 16b4faa22e4f..cf98f1af659e 100644
@@ -813,7 +813,7 @@ hdmiphy: phy@ff430000 {
};
cru: clock-controller@ff440000 {
- compatible = "rockchip,rk3328-cru", "rockchip,cru", "syscon";
+ compatible = "rockchip,rk3328-cru";
reg = <0x0 0xff440000 0x0 0x1000>;
rockchip,grf = <&grf>;
#clock-cells = <1>;
 
 

Recent Patches

About Us

Sed lacus. Donec lectus. Nullam pretium nibh ut turpis. Nam bibendum. In nulla tortor, elementum vel, tempor at, varius non, purus. Mauris vitae nisl nec metus placerat consectetuer.

Read More...