drm/rockchip: only call drm_fb_helper_hotplug_event if fb_helper present
From: Heiko Stuebner <heiko@...> Date: Tue, 2 Jun 2015 00:39:35 +0200
Commit-Message
Add a check for the presence of fb_helper to rockchip_drm_output_poll_changed() to only call drm_fb_helper_hotplug_event if there is actually a fb_helper available. Without this check I see NULL pointer dereferences when the hdmi hotplug irq fires before the fb_helper got initialized. Signed-off-by: Heiko Stuebner <heiko@...>
Patch-Comment
Fix to variant as seen on at least Exynos, Armada and Omap drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Statistics
- 2 lines added
- 1 lines removed
Changes
------------------ drivers/gpu/drm/rockchip/rockchip_drm_fb.c ------------------
index 77d5289..002645b 100644
@@ -162,7 +162,8 @@ static void rockchip_drm_output_poll_changed(struct drm_device *dev)
struct rockchip_drm_private *private = dev->dev_private;
struct drm_fb_helper *fb_helper = &private->fbdev_helper;
+ if (fb_helper)
+ drm_fb_helper_hotplug_event(fb_helper);
}
static const struct drm_mode_config_funcs rockchip_drm_mode_config_funcs = {