From: Heiko Stuebner <heiko@...>
Date: Wed, 22 Jul 2015 17:18:03 +0200
Commit-Message
According the Chris Zhong PMU_GPIOINT_WAKEUP_EN is needed when entering
the shallow suspend (with logic staying on), so enable it.
Testing revealed that this setting really is necessary to reliably
resume the veyron devices from suspend.
The question remains, why the deep sleep would not need this setting.
Signed-off-by: Heiko Stuebner <heiko@...>
Patch-Comment
arch/arm/mach-rockchip/pm.c | 9 ++++++---
arch/arm/mach-rockchip/pm.h | 1 +
2 files changed, 7 insertions(+), 3 deletions(-)
Statistics
- 7 lines added
- 3 lines removed
Changes
@@ -124,9 +124,6 @@ static void rk3288_slp_mode_set(int level)
regmap_write(sgrf_regmap, RK3288_SGRF_FAST_BOOT_ADDR,
rk3288_bootram_phy);
- regmap_write(pmu_regmap, RK3288_PMU_WAKEUP_CFG1,
- PMU_ARMINT_WAKEUP_EN);
-
mode_set = BIT(PMU_GLOBAL_INT_DISABLE) | BIT(PMU_L2FLUSH_EN) |
BIT(PMU_SREF0_ENTER_EN) | BIT(PMU_SREF1_ENTER_EN) |
BIT(PMU_DDR0_GATING_EN) | BIT(PMU_DDR1_GATING_EN) |
@@ -138,6 +135,9 @@ static void rk3288_slp_mode_set(int level)
mode_set1 = BIT(PMU_CLR_CORE) | BIT(PMU_CLR_CPUP);
if (level == ROCKCHIP_ARM_OFF_LOGIC_DEEP) {
+ regmap_write(pmu_regmap, RK3288_PMU_WAKEUP_CFG1,
+ PMU_ARMINT_WAKEUP_EN);
+
/* arm off, logic deep sleep */
mode_set |= BIT(PMU_BUS_PD_EN) | BIT(PMU_PMU_USE_LF) |
BIT(PMU_DDR1IO_RET_EN) | BIT(PMU_DDR0IO_RET_EN) |
@@ -152,6 +152,9 @@ static void rk3288_slp_mode_set(int level)
regmap_write(pmu_regmap, RK3288_PMU_OSC_CNT, 32 * 30);
regmap_write(pmu_regmap, RK3288_PMU_STABL_CNT, 32 * 30);
} else {
+ regmap_write(pmu_regmap, RK3288_PMU_WAKEUP_CFG1,
+ PMU_ARMINT_WAKEUP_EN | PMU_GPIOINT_WAKEUP_EN);
+
/*
* arm off, logic normal
* if pmu_clk_core_src_gate_en is not set,
@@ -61,6 +61,7 @@ static inline void rockchip_suspend_init(void)
/* PMU_WAKEUP_CFG1 bits */
#define PMU_ARMINT_WAKEUP_EN BIT(0)
+#define PMU_GPIOINT_WAKEUP_EN BIT(3)
enum rk3288_pwr_mode_con {
PMU_PWR_MODE_EN = 0,