phy: rockchip-emmc: should be a child device of the GRF
From: Heiko Stuebner <heiko@...> Date: Thu, 24 Mar 2016 11:54:24 +0100
Commit-Message
The emmc-phy is fully enclosed in the general register files (GRF). Therefore as seen from the device-tree it shouldn't be a separate platform- device but instead a sub-device of the GRF - using the simply-mfd mechanism. The driver entered the kernel in the current merge-window, so we can still adapt the binding without needing a fallback, as the binding hasn't been released with a full kernel yet. Signed-off-by: Heiko Stuebner <heiko@...>
Patch-Comment
Hi Shawn, Kishon, I didn't see this new phy driver until now, so I'd really like to get this sorted before the old binding solidifies :-). I'll convert the usbphy as well, but that has to have the fallback for the old binding, so is not as urgent as these two. As mentioned in the patch description above, this is meant as a fixup for kernel 4.6. One thing I noticed, the emmc phy is occupying the range 0xf780-0xf7a0, so shouldn't the reg property reflect that, like reg = <0xf780 0x20>; to stay with common conventions? .../devicetree/bindings/phy/rockchip-emmc-phy.txt | 19 ++++++++++++------- drivers/phy/phy-rockchip-emmc.c | 5 ++++- 2 files changed, 16 insertions(+), 8 deletions(-)
Statistics
- 16 lines added
- 8 lines removed