clk: rockchip: initialize flags of clk_init_data in mmc-phase clock

A patch from »clk: rockchip: initialize flags of clk_init_data in mmc-phase clock« in state Mainline for linux-kernel

From: Heiko Stuebner <heiko@...> Date: Tue, 17 May 2016 20:57:50 +0200

Commit-Message

The flags element of clk_init_data was never initialized for mmc- phase-clocks resulting in the element containing a random value and thus possibly enabling unwanted clock flags. Fixes: 89bf26cbc1a0 ("clk: rockchip: Add support for the mmc clock phases using the framework") Cc: stable@vger.kernel.org Signed-off-by: Heiko Stuebner <heiko@...>

Patch-Comment

Found while investigating the critical clock locking in __clk_core_init as it generated a bunch of warnings due to the (random) flags containing the critical clock bit in most cases. I've also already applied this to my fixes branch, so posted for reference. drivers/clk/rockchip/clk-mmc-phase.c | 1 + 1 file changed, 1 insertion(+)

Statistics

  • 1 lines added
  • 0 lines removed

Changes

--------------------- drivers/clk/rockchip/clk-mmc-phase.c ---------------------
index bc856f2..4601130 100644
@@ -154,6 +154,7 @@ struct clk *rockchip_clk_register_mmc(const char *name,
return ERR_PTR(-ENOMEM);
init.name = name;
+ init.flags = 0;
init.num_parents = num_parents;
init.parent_names = parent_names;
init.ops = &rockchip_mmc_clk_ops;
 
 

Recent Patches

About Us

Sed lacus. Donec lectus. Nullam pretium nibh ut turpis. Nam bibendum. In nulla tortor, elementum vel, tempor at, varius non, purus. Mauris vitae nisl nec metus placerat consectetuer.

Read More...